fix(mcp): coordinate OAuth token refresh and authorization polling
Prevent concurrent refresh-token rotation across instances, distinguish expired-but-refreshable tokens from active authorization, and bind OAuth popup polling to a per-attempt ID so stale tokens cannot satisfy new consent.
This commit is contained in:
@@ -2,6 +2,7 @@ package interfaces
|
||||
|
||||
import (
|
||||
"context"
|
||||
"time"
|
||||
|
||||
"github.com/Tencent/WeKnora/internal/types"
|
||||
)
|
||||
@@ -41,4 +42,23 @@ type MCPOAuthRepository interface {
|
||||
|
||||
// DeleteTokenForPrincipal removes the per-principal token for a service.
|
||||
DeleteTokenForPrincipal(ctx context.Context, tenantID uint64, principal types.Principal, serviceID string) error
|
||||
|
||||
// TryAcquireTokenRefreshLease atomically claims the right to use a refresh
|
||||
// token. This prevents concurrent instances from presenting the same
|
||||
// rotating refresh token to the authorization server.
|
||||
TryAcquireTokenRefreshLease(
|
||||
ctx context.Context,
|
||||
tenantID uint64,
|
||||
principal types.Principal,
|
||||
serviceID, leaseID string,
|
||||
leaseUntil time.Time,
|
||||
) (bool, error)
|
||||
|
||||
// ReleaseTokenRefreshLease releases a lease only when leaseID still owns it.
|
||||
ReleaseTokenRefreshLease(
|
||||
ctx context.Context,
|
||||
tenantID uint64,
|
||||
principal types.Principal,
|
||||
serviceID, leaseID string,
|
||||
) error
|
||||
}
|
||||
|
||||
@@ -85,8 +85,13 @@ type MCPOAuthToken struct {
|
||||
RefreshToken string `json:"-" gorm:"type:text"`
|
||||
TokenType string `json:"token_type" gorm:"type:varchar(32)"`
|
||||
ExpiresAt time.Time `json:"expires_at"`
|
||||
CreatedAt time.Time `json:"created_at"`
|
||||
UpdatedAt time.Time `json:"updated_at"`
|
||||
// RefreshLeaseID / RefreshLeaseUntil coordinate refresh-token rotation
|
||||
// across application instances. They are operational fields only and are
|
||||
// never exposed through the API.
|
||||
RefreshLeaseID string `json:"-" gorm:"type:varchar(36)"`
|
||||
RefreshLeaseUntil *time.Time `json:"-"`
|
||||
CreatedAt time.Time `json:"created_at"`
|
||||
UpdatedAt time.Time `json:"updated_at"`
|
||||
}
|
||||
|
||||
// TableName pins the table name (see MCPOAuthClient.TableName); the default
|
||||
|
||||
Reference in New Issue
Block a user