From 7eea22d655024ace256582d26782680ec6c8032e Mon Sep 17 00:00:00 2001 From: wizardchen Date: Wed, 8 Apr 2026 17:00:37 +0800 Subject: [PATCH] refactor: Enhance wiki link generation in summary processing - Updated the WikiSummaryPrompt to clarify the wiki-link syntax, specifying the use of slugs for referenced names. - Modified the extractEntitiesAndConcepts method to return a mapping of slugs to display names, improving the accuracy of wiki-link references in summaries. - Adjusted the summary content generation to include display names alongside slugs, enhancing the readability and context of generated summaries. These changes improve the clarity and usability of wiki summaries by ensuring accurate and consistent link references. --- internal/agent/prompts_wiki.go | 2 +- internal/application/service/wiki_ingest.go | 32 ++++++++++++++++----- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/internal/agent/prompts_wiki.go b/internal/agent/prompts_wiki.go index 1febdd7d..080910ca 100644 --- a/internal/agent/prompts_wiki.go +++ b/internal/agent/prompts_wiki.go @@ -25,7 +25,7 @@ const WikiSummaryPrompt = `You are a wiki editor. Given the following document c 2. After the SUMMARY line, write a comprehensive summary of the document in Markdown format. 3. Include the key facts, arguments, and conclusions. 4. Use proper heading hierarchy (## for sections, ### for subsections). -5. Use [[wiki-link]] syntax to reference the available wiki pages listed above. Use the EXACT slugs provided — do NOT invent new slugs. +5. **Wiki-link rule**: The available_wiki_pages list above maps slugs to display names (e.g. "[[entity/zhong-guo]] = 中国"). Whenever you mention a name that matches a listed entry, you MUST write it as [[slug]] (e.g. [[entity/zhong-guo]]), NOT as bold (**name**) or plain text. Use the EXACT slugs provided — do NOT invent new slugs. 6. At the end, include a "## Key Takeaways" section with bullet points. 7. Write in {{.Language}}. 8. Keep the summary concise but thorough (500-1500 words depending on document length). diff --git a/internal/application/service/wiki_ingest.go b/internal/application/service/wiki_ingest.go index 81396cd5..4c62ee1b 100644 --- a/internal/application/service/wiki_ingest.go +++ b/internal/application/service/wiki_ingest.go @@ -561,7 +561,7 @@ func (s *wikiIngestService) processOneDocument( } // Step 1: Extract entities and concepts - extractedPages, err := s.extractEntitiesAndConcepts(ctx, chatModel, content, docTitle, lang, docPayload, sourceRef, oldPageSlugs) + extractedPages, slugNames, err := s.extractEntitiesAndConcepts(ctx, chatModel, content, docTitle, lang, docPayload, sourceRef, oldPageSlugs) if err != nil { logger.Warnf(ctx, "wiki ingest: knowledge extraction failed for %s: %v", knowledgeID, err) } else { @@ -572,7 +572,11 @@ func (s *wikiIngestService) processOneDocument( summarySlug := fmt.Sprintf("summary/%s", slugify(docTitle)) var slugListing string for _, slug := range extractedPages { - slugListing += fmt.Sprintf("- [[%s]]\n", slug) + if name, ok := slugNames[slug]; ok { + slugListing += fmt.Sprintf("- [[%s]] = %s\n", slug, name) + } else { + slugListing += fmt.Sprintf("- [[%s]]\n", slug) + } } summaryContent, err := s.generateWithTemplate(ctx, chatModel, agent.WikiSummaryPrompt, map[string]string{ "Title": docTitle, @@ -921,7 +925,8 @@ type combinedExtraction struct { } // extractEntitiesAndConcepts performs a single LLM call to extract both entities and concepts, -// then upserts pages for each. Returns the list of successfully upserted page slugs. +// then upserts pages for each. Returns the list of successfully upserted page slugs and +// a slug→display name map for building wiki-link references. // oldPageSlugs contains slugs from the previous version of this document — passed to LLM for slug stability. func (s *wikiIngestService) extractEntitiesAndConcepts( ctx context.Context, @@ -930,7 +935,7 @@ func (s *wikiIngestService) extractEntitiesAndConcepts( payload WikiIngestPayload, sourceRef string, oldPageSlugs map[string]bool, -) ([]string, error) { +) ([]string, map[string]string, error) { // Build previous slugs listing for the prompt var prevSlugsText string if len(oldPageSlugs) > 0 { @@ -951,7 +956,7 @@ func (s *wikiIngestService) extractEntitiesAndConcepts( "PreviousSlugs": prevSlugsText, }) if err != nil { - return nil, fmt.Errorf("combined extraction failed: %w", err) + return nil, nil, fmt.Errorf("combined extraction failed: %w", err) } // Clean JSON - strip markdown code blocks if present @@ -964,7 +969,7 @@ func (s *wikiIngestService) extractEntitiesAndConcepts( var result combinedExtraction if err := json.Unmarshal([]byte(extractionJSON), &result); err != nil { logger.Warnf(ctx, "wiki ingest: failed to parse combined extraction JSON: %v\nRaw: %s", err, truncateString(extractionJSON, 500)) - return nil, fmt.Errorf("parse combined extraction JSON: %w", err) + return nil, nil, fmt.Errorf("parse combined extraction JSON: %w", err) } var affected []string @@ -975,6 +980,19 @@ func (s *wikiIngestService) extractEntitiesAndConcepts( // Deduplicate concepts against existing wiki pages (LLM-based) result.Concepts = s.deduplicateItems(ctx, chatModel, result.Concepts, types.WikiPageTypeConcept, payload.KnowledgeBaseID) + // Build slug→name map for wiki-link generation in summary pages + slugNames := make(map[string]string) + for _, item := range result.Entities { + if item.Slug != "" && item.Name != "" { + slugNames[item.Slug] = item.Name + } + } + for _, item := range result.Concepts { + if item.Slug != "" && item.Name != "" { + slugNames[item.Slug] = item.Name + } + } + // Upsert entity pages entitySlugs, err := s.upsertExtractedPages(ctx, chatModel, result.Entities, types.WikiPageTypeEntity, docTitle, lang, payload, sourceRef) if err != nil { @@ -991,7 +1009,7 @@ func (s *wikiIngestService) extractEntitiesAndConcepts( affected = append(affected, conceptSlugs...) } - return affected, nil + return affected, slugNames, nil } // upsertExtractedPages creates or updates wiki pages from pre-extracted items.