feat(cli): v0.9 contract harmonization
Make the agent-facing contract uniform across the whole surface: - cobra parse errors (unknown flag, arg-count) emit the JSON envelope by default, not bare prose — via a single DefaultFormatMode shared by the early resolver and ResolveDefault. - a malformed --jq is input.invalid_argument (exit 5), not internal.error. - destructive-confirmation messages name the real operation (edit/remove, not a hardcoded "delete"). - `doc wait` emits one envelope (Silent failure, no contradictory stderr); completed marshals as [] not null. - WEKNORA_AGENT_HELP covers every leaf command, enforced by a coverage drift guard; a sibling guard enforces --dry-run on every mutation. - `search docs`/`search chunks` resolve --kb through the same flag→env→project-link chain as `doc list`/`chat` (no longer a hard --kb requirement); a linked dir or WEKNORA_KB_ID now works without --kb, and an unresolved KB is local.kb_id_required (exit 1). The destructive `doc delete --all` keeps its explicit-only rule. - exit-code and batch/wait ok-semantics documented in the shared skill, README, and AGENTS.md.
This commit is contained in:
@@ -161,3 +161,31 @@ func TestRoot_ProfileFlagPropagation(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// resolveFormatEarly must default to the JSON envelope when no --format/env is
|
||||
// given, so cobra-side errors (unknown flag, arg-count) — which fire before
|
||||
// PersistentPreRunE runs ResolveDefault — emit a machine-readable envelope on
|
||||
// stderr, not bare prose. Regression for the success-path-defaults-to-json /
|
||||
// error-path-defaults-to-prose asymmetry.
|
||||
func TestResolveFormatEarly_DefaultsToEnvelope(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
args []string
|
||||
want bool // true ⇒ expect JSON envelope
|
||||
}{
|
||||
{"no format flag (default)", []string{"kb", "view"}, true},
|
||||
{"explicit --format json", []string{"kb", "view", "--format", "json"}, true},
|
||||
{"explicit --format text", []string{"kb", "view", "--format", "text"}, false},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
resolveFormatEarly(tc.args)
|
||||
err := MapCobraError(errors.New("accepts 1 arg(s), received 0"))
|
||||
var buf bytes.Buffer
|
||||
cmdutil.PrintError(&buf, err)
|
||||
isEnvelope := strings.HasPrefix(strings.TrimSpace(buf.String()), "{")
|
||||
assert.Equal(t, tc.want, isEnvelope,
|
||||
"args=%v: got %q", tc.args, buf.String())
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user