From 63caf564ee7151ebcf577ce806ca110266c72b43 Mon Sep 17 00:00:00 2001 From: wizardchen Date: Mon, 16 Mar 2026 17:49:45 +0800 Subject: [PATCH] feat: support manual knowledge download in GetKnowledgeFile Add an early-return branch that streams manual knowledge content (stored as Markdown in Metadata.content) directly as a .md file, avoiding the runtime error that occurred when FilePath is empty. Co-Authored-By: Claude Sonnet 4.6 --- internal/application/service/knowledge.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/internal/application/service/knowledge.go b/internal/application/service/knowledge.go index 6233baff..42961c8b 100644 --- a/internal/application/service/knowledge.go +++ b/internal/application/service/knowledge.go @@ -2414,6 +2414,25 @@ func (s *knowledgeService) GetKnowledgeFile(ctx context.Context, id string) (io. return nil, "", err } + // Manual knowledge stores content in Metadata — stream it directly as a .md file. + if knowledge.IsManual() { + meta, err := knowledge.ManualMetadata() + if err != nil { + return nil, "", err + } + // ManualMetadata returns (nil, nil) when Metadata column is empty; treat as empty content. + content := "" + if meta != nil { + content = meta.Content + } + // Sanitize title: strip characters that are invalid or dangerous in HTTP headers / filenames. + safeName := strings.NewReplacer( + "\n", "", "\r", "", "/", "-", "\\", "-", "\"", "'", + ).Replace(knowledge.Title) + filename := safeName + ".md" + return io.NopCloser(strings.NewReader(content)), filename, nil + } + // Resolve KB-level file service with FilePath fallback protection kb, _ := s.kbService.GetKnowledgeBaseByID(ctx, knowledge.KnowledgeBaseID) file, err := s.resolveFileServiceForPath(ctx, kb, knowledge.FilePath).GetFile(ctx, knowledge.FilePath)