fix(agent): reconcile agent stream mode and shared-agent readiness UX
Derive stream pipeline from selectedAgentId to fix quick-answer/isAgentEnabled drift, gate configure actions for shared agents, and polish selector detail panel positioning.
This commit is contained in:
@@ -0,0 +1,59 @@
|
||||
import assert from 'node:assert/strict'
|
||||
import test from 'node:test'
|
||||
|
||||
const BUILTIN_QUICK_ANSWER_ID = 'builtin-quick-answer'
|
||||
const BUILTIN_SMART_REASONING_ID = 'builtin-smart-reasoning'
|
||||
|
||||
function isQuickAnswerAgentId(agentId) {
|
||||
return (agentId || BUILTIN_QUICK_ANSWER_ID) === BUILTIN_QUICK_ANSWER_ID
|
||||
}
|
||||
|
||||
function isAgentStreamAgentId(agentId, isAgentEnabled) {
|
||||
const id = agentId || BUILTIN_QUICK_ANSWER_ID
|
||||
if (id === BUILTIN_QUICK_ANSWER_ID) return false
|
||||
if (id === BUILTIN_SMART_REASONING_ID) return true
|
||||
return isAgentEnabled
|
||||
}
|
||||
|
||||
function reconcileBuiltinAgentMode(settings) {
|
||||
const agentId = settings.selectedAgentId || BUILTIN_QUICK_ANSWER_ID
|
||||
if (agentId === BUILTIN_QUICK_ANSWER_ID && settings.isAgentEnabled) {
|
||||
settings.isAgentEnabled = false
|
||||
return true
|
||||
}
|
||||
if (agentId === BUILTIN_SMART_REASONING_ID && !settings.isAgentEnabled) {
|
||||
settings.isAgentEnabled = true
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
test('isQuickAnswerAgentId treats builtin quick-answer as RAG mode', () => {
|
||||
assert.equal(isQuickAnswerAgentId('builtin-quick-answer'), true)
|
||||
assert.equal(isQuickAnswerAgentId(undefined), true)
|
||||
assert.equal(isQuickAnswerAgentId('builtin-smart-reasoning'), false)
|
||||
})
|
||||
|
||||
test('isAgentStreamAgentId prefers selectedAgentId for builtins', () => {
|
||||
assert.equal(
|
||||
isAgentStreamAgentId('builtin-quick-answer', true),
|
||||
false,
|
||||
'stale isAgentEnabled must not flip quick-answer into agent stream',
|
||||
)
|
||||
assert.equal(isAgentStreamAgentId('builtin-smart-reasoning', false), true)
|
||||
assert.equal(isAgentStreamAgentId('custom-agent', true), true)
|
||||
assert.equal(isAgentStreamAgentId('custom-agent', false), false)
|
||||
})
|
||||
|
||||
test('reconcileBuiltinAgentMode repairs drifted localStorage flags', () => {
|
||||
const quick = { selectedAgentId: 'builtin-quick-answer', isAgentEnabled: true }
|
||||
assert.equal(reconcileBuiltinAgentMode(quick), true)
|
||||
assert.equal(quick.isAgentEnabled, false)
|
||||
|
||||
const reasoning = { selectedAgentId: 'builtin-smart-reasoning', isAgentEnabled: false }
|
||||
assert.equal(reconcileBuiltinAgentMode(reasoning), true)
|
||||
assert.equal(reasoning.isAgentEnabled, true)
|
||||
|
||||
const custom = { selectedAgentId: 'custom-agent', isAgentEnabled: true }
|
||||
assert.equal(reconcileBuiltinAgentMode(custom), false)
|
||||
})
|
||||
Reference in New Issue
Block a user