From 5c31a9123f863df773b0396b481754ce710d2eab Mon Sep 17 00:00:00 2001 From: Andy Yang Date: Thu, 19 Mar 2026 18:50:32 +0800 Subject: [PATCH] fix: Adjust temperature validation to allow zero as a valid setting and default only for negative values. --- internal/application/service/session_qa_helpers.go | 2 +- internal/handler/session/helpers.go | 4 ++-- internal/types/custom_agent.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/application/service/session_qa_helpers.go b/internal/application/service/session_qa_helpers.go index 5302f145..1a6266bb 100644 --- a/internal/application/service/session_qa_helpers.go +++ b/internal/application/service/session_qa_helpers.go @@ -118,7 +118,7 @@ func (s *sessionService) applyAgentOverridesToChatManage( cm.SummaryConfig.ContextTemplate = customAgent.Config.ContextTemplate logger.Infof(ctx, "Using custom agent's context_template") } - if customAgent.Config.Temperature > 0 { + if customAgent.Config.Temperature >= 0 { cm.SummaryConfig.Temperature = customAgent.Config.Temperature logger.Infof(ctx, "Using custom agent's temperature: %f", customAgent.Config.Temperature) } diff --git a/internal/handler/session/helpers.go b/internal/handler/session/helpers.go index 783e57a1..32dcede2 100644 --- a/internal/handler/session/helpers.go +++ b/internal/handler/session/helpers.go @@ -286,7 +286,7 @@ func (h *Handler) createDefaultSummaryConfig(ctx context.Context) *types.Summary if tenant.ConversationConfig.ContextTemplate != "" { cfg.ContextTemplate = tenant.ConversationConfig.ContextTemplate } - if tenant.ConversationConfig.Temperature > 0 { + if tenant.ConversationConfig.Temperature >= 0 { cfg.Temperature = tenant.ConversationConfig.Temperature } if tenant.ConversationConfig.MaxCompletionTokens > 0 { @@ -344,7 +344,7 @@ func (h *Handler) fillSummaryConfigDefaults(ctx context.Context, config *types.S if config.ContextTemplate == "" { config.ContextTemplate = defaultContextTemplate } - if config.Temperature == 0 { + if config.Temperature < 0 { config.Temperature = defaultTemperature } if config.MaxCompletionTokens == 0 { diff --git a/internal/types/custom_agent.go b/internal/types/custom_agent.go index 29575a85..9937f442 100644 --- a/internal/types/custom_agent.go +++ b/internal/types/custom_agent.go @@ -211,7 +211,7 @@ func (a *CustomAgent) EnsureDefaults() { if a == nil { return } - if a.Config.Temperature == 0 { + if a.Config.Temperature < 0 { a.Config.Temperature = 0.7 } if a.Config.MaxIterations == 0 {