fix(chunking): post-review polish — error surfacing + doc accuracy
Three small follow-ups from the QA review of 13f57ca:
1. KBChunkingDebug error surfacing
Previously a 200 OK response with { success: false, error: "..." }
would have been swallowed under a generic "unexpected response shape"
message. The strict-shape check now distinguishes empty response,
success=false (surfaces resp.error directly), and missing data — so
any future backend-side validation message reaches the user.
2. Token approximation in docs/CHUNKING.md
Child Chunk Size default 384 ≈ 95 EN tokens (was rounded to 80).
384 / 4 chars-per-token = 96; "~95" is the honest figure.
3. API surface in docs/CHUNKING.md
The example only documented PUT /initialization/config/:kbId
(camelCase, documentSplitting envelope). Added explicit notes that
POST/PUT /knowledge-bases use snake_case under chunking_config, and
that POST /chunker/preview also uses the snake_case form plus a text
field. Readers picking the wrong endpoint won't be surprised by the
case mismatch anymore.
https://claude.ai/code/session_01XADhx6mtu2ZYW3DE9Lun6k
This commit is contained in:
@@ -209,8 +209,16 @@ const runPreview = async () => {
|
||||
// The axios interceptor in utils/request.ts already unwraps the
|
||||
// outer envelope and returns the response body. So resp here is
|
||||
// { success: true, data: PreviewChunkingResponse } directly.
|
||||
if (!resp || resp.success !== true || !resp.data) {
|
||||
throw new Error('unexpected response shape')
|
||||
// If the backend ever responds with 200 + { success: false, error },
|
||||
// surface that error instead of swallowing it under a generic message.
|
||||
if (!resp) {
|
||||
throw new Error('empty response')
|
||||
}
|
||||
if (resp.success !== true) {
|
||||
throw new Error((resp as any).error || 'preview failed')
|
||||
}
|
||||
if (!resp.data) {
|
||||
throw new Error('response missing data')
|
||||
}
|
||||
result.value = resp.data
|
||||
} catch (e: any) {
|
||||
|
||||
Reference in New Issue
Block a user