fix(tasks): dequeue work for deleted knowledge bases

This commit is contained in:
zhangzherui
2026-07-23 04:51:40 +08:00
committed by lyingbug
parent 7fde37eeeb
commit 37de0afad0
14 changed files with 1575 additions and 194 deletions
@@ -7,6 +7,7 @@ import (
"time"
"github.com/Tencent/WeKnora/internal/types"
"github.com/Tencent/WeKnora/internal/types/interfaces"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gorm.io/driver/sqlite"
@@ -182,6 +183,110 @@ func TestTaskPendingOps_DeleteByIDs_RemovesOnlyTargets(t *testing.T) {
assert.Equal(t, "b", got[0].DedupKey)
}
func TestTaskPendingOps_DeleteByScope_RemovesAllTaskTypesAndIsolatesScopes(t *testing.T) {
db := setupTaskQueueTestDB(t)
repo := NewTaskPendingOpsRepository(db)
cleaner, ok := repo.(interfaces.TaskPendingOpsScopeCleaner)
require.True(t, ok)
ctx := context.Background()
// The deleted KB can have durable work in more than one wiki queue.
require.NoError(t, repo.Enqueue(ctx,
makePendingOp(types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb-delete", "ingest", "k1", nil)))
require.NoError(t, repo.Enqueue(ctx,
makePendingOp(types.TypeWikiFinalize, types.TaskScopeKnowledgeBase, "kb-delete", "finalize", "k2", nil)))
// Rows in another KB or another scope must survive even when their IDs or
// task types overlap with the deleted KB.
require.NoError(t, repo.Enqueue(ctx,
makePendingOp(types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb-keep", "ingest", "k3", nil)))
require.NoError(t, repo.Enqueue(ctx,
makePendingOp(types.TypeWikiFinalize, types.TaskScopeKnowledge, "kb-delete", "finalize", "k4", nil)))
require.NoError(t, cleaner.DeleteByScope(ctx, types.TaskScopeKnowledgeBase, "kb-delete"))
var remaining []*types.TaskPendingOp
require.NoError(t, db.Order("id ASC").Find(&remaining).Error)
require.Len(t, remaining, 2)
assert.Equal(t, "kb-keep", remaining[0].ScopeID)
assert.Equal(t, types.TaskScopeKnowledge, remaining[1].Scope)
assert.Equal(t, "kb-delete", remaining[1].ScopeID)
}
func TestTaskPendingOps_DeleteByScope_RejectsMissingScope(t *testing.T) {
db := setupTaskQueueTestDB(t)
repo := NewTaskPendingOpsRepository(db)
cleaner, ok := repo.(interfaces.TaskPendingOpsScopeCleaner)
require.True(t, ok)
ctx := context.Background()
require.NoError(t, repo.Enqueue(ctx,
makePendingOp(types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb", "ingest", "k1", nil)))
assert.Error(t, cleaner.DeleteByScope(ctx, "", "kb"))
assert.Error(t, cleaner.DeleteByScope(ctx, types.TaskScopeKnowledgeBase, ""))
var count int64
require.NoError(t, db.Model(&types.TaskPendingOp{}).Count(&count).Error)
assert.Equal(t, int64(1), count)
}
func TestTaskPendingOps_EnqueueIfKnowledgeBaseActive(t *testing.T) {
db := setupTaskQueueTestDB(t)
require.NoError(t, db.Exec(`CREATE TABLE knowledge_bases (
id VARCHAR(64) PRIMARY KEY,
tenant_id INTEGER NOT NULL,
deleted_at DATETIME
)`).Error)
require.NoError(t, db.Exec(
"INSERT INTO knowledge_bases (id, tenant_id, deleted_at) VALUES (?, ?, NULL), (?, ?, ?)",
"kb-active", 1, "kb-deleted", 1, time.Now(),
).Error)
repo := NewTaskPendingOpsRepository(db)
guard, ok := repo.(interfaces.TaskPendingOpsKnowledgeBaseGuard)
require.True(t, ok)
ctx := context.Background()
accepted, err := guard.EnqueueIfKnowledgeBaseActive(ctx,
makePendingOp(types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb-active", "ingest", "active", nil))
require.NoError(t, err)
assert.True(t, accepted)
for _, tc := range []struct {
name string
op *types.TaskPendingOp
}{
{
name: "soft deleted",
op: makePendingOp(
types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb-deleted", "ingest", "deleted", nil,
),
},
{
name: "missing",
op: makePendingOp(
types.TypeWikiIngest, types.TaskScopeKnowledgeBase, "kb-missing", "ingest", "missing", nil,
),
},
{name: "tenant mismatch", op: &types.TaskPendingOp{
TenantID: 2, TaskType: types.TypeWikiIngest, Scope: types.TaskScopeKnowledgeBase,
ScopeID: "kb-active", Op: "ingest", DedupKey: "wrong-tenant",
}},
} {
t.Run(tc.name, func(t *testing.T) {
accepted, err := guard.EnqueueIfKnowledgeBaseActive(ctx, tc.op)
require.NoError(t, err)
assert.False(t, accepted)
})
}
var rows []*types.TaskPendingOp
require.NoError(t, db.Find(&rows).Error)
require.Len(t, rows, 1)
assert.Equal(t, "active", rows[0].DedupKey)
}
// TestTaskPendingOps_IncrFailCount_ReturnsNewValueAndPersists exercises
// the UPDATE...RETURNING flow. Successive bumps should observe monotonic
// counts.