diff --git a/docs/superpowers/specs/2026-03-16-manual-knowledge-download-design.md b/docs/superpowers/specs/2026-03-16-manual-knowledge-download-design.md
index aafc9893..c11ed42e 100644
--- a/docs/superpowers/specs/2026-03-16-manual-knowledge-download-design.md
+++ b/docs/superpowers/specs/2026-03-16-manual-knowledge-download-design.md
@@ -33,19 +33,34 @@ if knowledge.IsManual() {
if err != nil {
return nil, "", err
}
- content := io.NopCloser(strings.NewReader(meta.Content))
- filename := knowledge.Title + ".md"
- return content, filename, nil
+ // ManualMetadata returns (nil, nil) when Metadata column is empty;
+ // treat as empty content rather than an error.
+ content := ""
+ if meta != nil {
+ content = meta.Content
+ }
+ // Sanitize title for use as a filename: strip newlines and path separators.
+ safeName := strings.NewReplacer(
+ "\n", "", "\r", "", "/", "-", "\\", "-", "\"", "'",
+ ).Replace(knowledge.Title)
+ filename := safeName + ".md"
+ return io.NopCloser(strings.NewReader(content)), filename, nil
}
```
- No new routes, handlers, or services required.
- All existing permission checks, logging, and error middleware remain intact.
-- The handler sets `Content-Disposition: attachment; filename="{title}.md"` via the existing streaming logic.
+- The handler sets `Content-Disposition: attachment; filename="{safeName}.md"` via the existing streaming logic.
+
+#### Non-ASCII filenames in `Content-Disposition`
+
+The existing handler writes the filename unquoted and without RFC 5987 encoding (`filename*=UTF-8''...`). This is a **known limitation inherited from the existing file-type download path** and is out of scope for this change. Most modern browsers (Chrome, Edge, Firefox) tolerate unquoted UTF-8 values in practice. A follow-up issue should address RFC 5987 encoding for all download types.
### Frontend — `frontend/src/components/doc-content.vue`
-Add a download button to the existing `manual` type UI block:
+Two changes are required:
+
+**1. Add download button to the `manual` UI block:**
```vue
@@ -53,14 +68,25 @@ Add a download button to the existing `manual` type UI block:
{{ details.title }}
-
+
```
-`downloadFile()` is already implemented and calls `downKnowledgeDetails(id)` → `GET /api/v1/knowledge/:id/download`. No changes needed to the API layer.
+**2. Fix `link.download` attribute in `downloadFile()` for manual type:**
+
+The existing `downloadFile()` function sets `link.setAttribute("download", props.details.title)` without an extension. Browsers use the `download` attribute — not `Content-Disposition` — as the saved filename when `URL.createObjectURL` is used. For `manual` type, append `.md`:
+
+```ts
+const filename = details.value.type === 'manual'
+ ? details.value.title + '.md'
+ : details.value.title
+link.setAttribute('download', filename)
+```
+
+`downloadFile()` otherwise calls `downKnowledgeDetails(id)` → `GET /api/v1/knowledge/:id/download` unchanged.
---
@@ -68,23 +94,30 @@ Add a download button to the existing `manual` type UI block:
```
User clicks download
- → downloadFile() [frontend]
+ → downloadFile() [frontend, sets link.download = "{title}.md" for manual type]
→ GET /api/v1/knowledge/:id/download
→ DownloadKnowledgeFile handler [validates access]
→ GetKnowledgeFile service
- → if manual: read Metadata.content → io.NopCloser(strings.NewReader(content))
- → return (ReadCloser, "{title}.md", nil)
+ → if manual: sanitize title, read Metadata.content (empty string if nil)
+ → return (ReadCloser, "{safeName}.md", nil)
→ handler streams response with Content-Disposition header
→ browser saves "{title}.md"
```
---
+## Side Effects
+
+`PreviewKnowledgeFile` also calls `GetKnowledgeFile` internally. After this change, preview requests for `manual` items will also succeed (returning the Markdown content with `text/markdown` MIME type via the existing `mimeTypeByExt(".md")` lookup). This is a desirable side effect and requires no additional changes.
+
+---
+
## Error Handling
| Scenario | Behaviour |
|----------|-----------|
| `ManualMetadata()` parse error | Returns internal server error (existing error middleware handles it) |
+| `ManualMetadata()` returns `nil` (empty Metadata column) | Treated as empty content; returns a valid empty `.md` file |
| Empty content (`""`) | Returns a valid empty `.md` file — not an error |
| Non-existent knowledge ID | Existing 404 handling unchanged |
| Insufficient permissions | Existing auth middleware unchanged |
@@ -93,6 +126,7 @@ User clicks download
## Out of Scope
+- RFC 5987 encoding for non-ASCII `Content-Disposition` filenames (affects all download types, tracked separately)
- HTML / PDF / plain-text export formats
- Batch download of multiple knowledge items
- Version history download