From 2fd6e226a581f53bbaf27bcf3f0e2775f0b2a00f Mon Sep 17 00:00:00 2001 From: wizardchen Date: Mon, 16 Mar 2026 18:18:23 +0800 Subject: [PATCH] fix: sanitize tab chars and avoid double .md extension in manual download filename Co-Authored-By: Claude Sonnet 4.6 --- internal/application/service/knowledge.go | 7 +++++-- internal/application/service/knowledge_manual_test.go | 10 ++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/internal/application/service/knowledge.go b/internal/application/service/knowledge.go index 1738f539..c9666b08 100644 --- a/internal/application/service/knowledge.go +++ b/internal/application/service/knowledge.go @@ -6752,12 +6752,15 @@ func ensureManualFileName(title string) string { // back to "untitled". func sanitizeManualDownloadFilename(title string) string { safeName := strings.NewReplacer( - "\n", "", "\r", "", "/", "-", "\\", "-", "\"", "'", + "\n", "", "\r", "", "\t", "", "/", "-", "\\", "-", "\"", "'", ).Replace(title) if strings.TrimSpace(safeName) == "" { safeName = "untitled" } - return safeName + manualFileExtension + if !strings.HasSuffix(strings.ToLower(safeName), manualFileExtension) { + safeName += manualFileExtension + } + return safeName } func (s *knowledgeService) triggerManualProcessing(ctx context.Context, diff --git a/internal/application/service/knowledge_manual_test.go b/internal/application/service/knowledge_manual_test.go index 3022b0a0..f21410f2 100644 --- a/internal/application/service/knowledge_manual_test.go +++ b/internal/application/service/knowledge_manual_test.go @@ -72,6 +72,16 @@ func TestSanitizeManualDownloadFilename(t *testing.T) { title: "知识库文章", want: "知识库文章.md", }, + { + name: "tab character stripped", + title: "file\tname", + want: "filename.md", + }, + { + name: "title already ending in .md not double-extended", + title: "guide.md", + want: "guide.md", + }, } for _, tt := range tests {