feat(cli): --log-level + kb/agent status & check + cross-cutting refactor
Operability surface and the bulk of the jopts→fopts migration: * --log-level error|warn|info|debug + WEKNORA_LOG_LEVEL env, wired to the SDK via client.SetDebugLevel. Invalid --log-level returns FlagError (exit 2). * kb status <kb-id> / kb check <kb-id> verb split (1 HTTP vs 1+N for failed_count aggregation). * agent status <agent-id> / agent check <agent-id> verb split (probes kb_scope_all_reachable via 1+N HTTP). * kb create <name> positional (matches agent create). * Positional id help strings namespaced (<kb-id> / <agent-id>). * All auth / context / link / doctor / kb / agent CRUD commands migrated to the FormatOptions API. * root.go Execute(ctx) takes a context so signal-cancellation propagates via cmd.Context() into long-running commands. * Pagination termination uses len(accum) >= total (not page*pageSize) so server-capped page sizes do not truncate aggregations.
This commit is contained in:
@@ -0,0 +1,53 @@
|
||||
package cmdutil
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"testing"
|
||||
|
||||
"github.com/spf13/cobra"
|
||||
)
|
||||
|
||||
func TestResolveLogLevel(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
flagVal string // "" means flag not set
|
||||
envVal string // WEKNORA_LOG_LEVEL
|
||||
wantLvl string
|
||||
wantWarn bool
|
||||
}{
|
||||
{"default", "", "", "error", false},
|
||||
{"flag wins over env", "debug", "info", "debug", false},
|
||||
{"env when no flag", "", "info", "info", false},
|
||||
{"invalid env falls through to default", "", "trace", "error", false},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
t.Setenv("WEKNORA_LOG_LEVEL", tc.envVal)
|
||||
|
||||
cmd := &cobra.Command{}
|
||||
AddLogLevelFlag(cmd)
|
||||
if tc.flagVal != "" {
|
||||
if err := cmd.ParseFlags([]string{"--log-level", tc.flagVal}); err != nil {
|
||||
t.Fatalf("ParseFlags: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
var stderr bytes.Buffer
|
||||
got, warn := ResolveLogLevel(cmd, &stderr)
|
||||
if got != tc.wantLvl {
|
||||
t.Errorf("level=%q want %q", got, tc.wantLvl)
|
||||
}
|
||||
if warn != tc.wantWarn {
|
||||
t.Errorf("warn=%v want %v", warn, tc.wantWarn)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestAddLogLevelFlag_RegistersPersistent(t *testing.T) {
|
||||
cmd := &cobra.Command{}
|
||||
AddLogLevelFlag(cmd)
|
||||
if f := cmd.PersistentFlags().Lookup("log-level"); f == nil {
|
||||
t.Error("--log-level must be registered as a persistent flag (global across all subcommands)")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user