fix: mark knowledge delete failures after retry exhaustion

This commit is contained in:
langcaiye
2026-06-16 12:08:00 +08:00
committed by lyingbug
parent 6efd2093f5
commit 0c3d45d3cd
6 changed files with 120 additions and 0 deletions
@@ -91,6 +91,20 @@ func reloadKnowledgeRow(t *testing.T, db *gorm.DB, id string) (status string, co
return status, count
}
func insertKnowledgeWithStatus(t *testing.T, db *gorm.DB, status string, deleted bool) string {
t.Helper()
id := uuid.New().String()
deletedAt := interface{}(nil)
if deleted {
deletedAt = "2026-06-16 12:00:00"
}
require.NoError(t, db.Exec(`
INSERT INTO knowledges (id, tenant_id, knowledge_base_id, type, title, source, parse_status, deleted_at)
VALUES (?, 1, ?, 'document', 'delete-test', 'manual', ?, ?)
`, id, uuid.New().String(), status, deletedAt).Error)
return id
}
// TestFinalizeSubtask_Concurrent_ExactlyOnePromote spawns N goroutines that
// each call FinalizeSubtask after SetFinalizing(N), and asserts:
// - the counter ends at zero,
@@ -268,3 +282,39 @@ func TestUpdateKnowledge_PendingCounterOmittedOnReset(t *testing.T) {
_, count = reloadKnowledgeRow(t, db, id)
assert.Equal(t, 0, count)
}
func TestUpdateActiveDeletingKnowledgeColumns_GuardsStateAndSoftDelete(t *testing.T) {
db := setupKnowledgeTestDB(t)
repo := NewKnowledgeRepository(db).(*knowledgeRepository)
ctx := context.Background()
activeDeletingID := insertKnowledgeWithStatus(t, db, types.ParseStatusDeleting, false)
activeCompletedID := insertKnowledgeWithStatus(t, db, types.ParseStatusCompleted, false)
deletedDeletingID := insertKnowledgeWithStatus(t, db, types.ParseStatusDeleting, true)
updated, err := repo.UpdateActiveDeletingKnowledgeColumns(ctx, activeDeletingID, map[string]interface{}{
"parse_status": types.ParseStatusFailed,
"error_message": "delete task exhausted retries",
})
require.NoError(t, err)
assert.True(t, updated)
updated, err = repo.UpdateActiveDeletingKnowledgeColumns(ctx, activeCompletedID, map[string]interface{}{
"parse_status": types.ParseStatusFailed,
})
require.NoError(t, err)
assert.False(t, updated)
updated, err = repo.UpdateActiveDeletingKnowledgeColumns(ctx, deletedDeletingID, map[string]interface{}{
"parse_status": types.ParseStatusFailed,
})
require.NoError(t, err)
assert.False(t, updated)
status, _ := reloadKnowledgeRow(t, db, activeDeletingID)
assert.Equal(t, types.ParseStatusFailed, status)
status, _ = reloadKnowledgeRow(t, db, activeCompletedID)
assert.Equal(t, types.ParseStatusCompleted, status)
status, _ = reloadKnowledgeRow(t, db, deletedDeletingID)
assert.Equal(t, types.ParseStatusDeleting, status)
}