fix(security): block refresh tokens as bearer and sandbox MCP uploads
Reject refresh JWTs in ValidateToken, revoke all user sessions on logout, and restrict create_knowledge_from_file to allowed directories on network MCP transports.
This commit is contained in:
@@ -0,0 +1,59 @@
|
||||
#!/usr/bin/env python3
|
||||
import os
|
||||
import tempfile
|
||||
import unittest
|
||||
|
||||
from upload_paths import resolve_upload_file_path
|
||||
|
||||
|
||||
class ResolveUploadFilePathTest(unittest.TestCase):
|
||||
def setUp(self):
|
||||
self._old_transport = os.environ.get("MCP_TRANSPORT")
|
||||
self._old_roots = os.environ.get("MCP_ALLOWED_UPLOAD_DIRS")
|
||||
|
||||
def tearDown(self):
|
||||
if self._old_transport is None:
|
||||
os.environ.pop("MCP_TRANSPORT", None)
|
||||
else:
|
||||
os.environ["MCP_TRANSPORT"] = self._old_transport
|
||||
if self._old_roots is None:
|
||||
os.environ.pop("MCP_ALLOWED_UPLOAD_DIRS", None)
|
||||
else:
|
||||
os.environ["MCP_ALLOWED_UPLOAD_DIRS"] = self._old_roots
|
||||
|
||||
def test_network_transport_blocks_path_outside_cwd(self):
|
||||
os.environ["MCP_TRANSPORT"] = "http"
|
||||
with tempfile.TemporaryDirectory() as tmp:
|
||||
os.chdir(tmp)
|
||||
allowed = os.path.join(tmp, "note.txt")
|
||||
with open(allowed, "w", encoding="utf-8") as handle:
|
||||
handle.write("ok")
|
||||
|
||||
resolved = resolve_upload_file_path("note.txt")
|
||||
self.assertEqual(resolved, os.path.realpath(allowed))
|
||||
|
||||
with self.assertRaises(ValueError):
|
||||
resolve_upload_file_path("/etc/passwd")
|
||||
|
||||
def test_explicit_allowed_roots(self):
|
||||
with tempfile.TemporaryDirectory() as tmp:
|
||||
os.environ["MCP_ALLOWED_UPLOAD_DIRS"] = tmp
|
||||
allowed = os.path.join(tmp, "doc.md")
|
||||
with open(allowed, "w", encoding="utf-8") as handle:
|
||||
handle.write("hello")
|
||||
|
||||
resolved = resolve_upload_file_path(os.path.join(tmp, "doc.md"))
|
||||
self.assertEqual(resolved, os.path.realpath(allowed))
|
||||
|
||||
outside = tempfile.NamedTemporaryFile(delete=False)
|
||||
try:
|
||||
outside.write(b"secret")
|
||||
outside.close()
|
||||
with self.assertRaises(ValueError):
|
||||
resolve_upload_file_path(outside.name)
|
||||
finally:
|
||||
os.unlink(outside.name)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user